From: Jeff King <peff@peff.net>
Date: Wed, 16 Sep 2020 18:41:04 GMT
Subject: Re: [PATCH 07/15] remote-mediawiki tests: guard test_cmp with test_path_is_file
Message-ID: <20200916184104.GB33925@coredump.intra.peff.net>
In-Reply-To: <20200916102918.29805-8-avarab@gmail.com>

On Wed, Sep 16, 2020 at 12:29:10PM +0200, Ævar Arnfjörð Bjarmason wrote:

> Change a test that used a plain test_cmp to first check the file(s)
> using test_path_is_file. If some of these file(s) don't exist (as
> happened to me during debugging), test_cmp will emit a way less useful
> message about the failure.

This seems like a problem that would exist in basically every test that
uses test_cmp (well, many of them do ">actual", so it's unlikely that
the content would be missing, but it would be true of any test that
expects a command to generate a file).

Rather than annotate each site, could we teach test_cmp to show a nicer
message?

-Peff