Re: [PATCH 07/15] remote-mediawiki tests: guard test_cmp with test_path_is_file

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sep 16, 2020, 16:53 UTC
Message-ID: <CAPig+cRg2tuOiQH_CQoHMjkX2gbRPJoV8NPJZnu3=bfo4wk-cQ@mail.gmail.com>
In-Reply-To: <20200916102918.29805-8-avarab@gmail.com>

On Wed, Sep 16, 2020 at 8:17 AM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

> Change a test that used a plain test_cmp to first check the file(s)
> using test_path_is_file. If some of these file(s) don't exist (as
> happened to me during debugging), test_cmp will emit a way less useful
> message about the failure.

An alternative would be to update test_cmp() to present a more helpful error message so that all test scripts can benefit rather than just this script. By the way, were you testing with a reasonably recent version of Git? I ask because test_cmp() was updated not long ago to provide better diagnostics when one of the files is missing.

[1]: d572f52a64 (test_cmp: diagnose incorrect arguments, 2020-08-09)