Re: [PATCH 06/15] remote-mediawiki tests: use test_cmp in tests
On Wed, Sep 16, 2020 at 12:29:09PM +0200, Ævar Arnfjörð Bjarmason wrote:
> Change code that used an ad-hoc diff invocation to use our test_cmp
> helper instead. I'm also changing the order of arguments to be the
> standard "test_cmp <expected> <actual>".
Definitely a positive direction, but...
Show 11 quoted lines
> diff --git a/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh b/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh
> index 9106833578..4c39bda7bf 100755
> --- a/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh
> +++ b/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh
> @@ -28,7 +28,7 @@ test_expect_success 'Git clone creates the expected git log with one file' '
> git log --format=%s HEAD^..HEAD >log.tmp
> ) &&
> echo "this must be the same" >msg.tmp &&
> - diff -b mw_dir_1/log.tmp msg.tmp
> + test_cmp msg.tmp mw_dir_1/log.tmp
> '
...the original was ignoring whitespace. Is that not important?
-Peff
Jeff King <peff@peff.net>