Re: [PATCH 1/2] Wait for child on signal death for aliases to builtins
- From
Trygve Aaberge <trygveaa@gmail.com>
- Date
- Jul 7, 2020, 10:23 UTC
- Message-ID
- <20200707102355.2kukfzxt7vhhenfy@aaberge.net>
- In-Reply-To
- <xmqqwo3g6qlu.fsf@gitster.c.googlers.com>
On Mon, Jul 06, 2020 at 18:50:05 -0700, Junio C Hamano wrote:
> True, as Dscho also mentioned. I'll just do "b914084007" => > "ee4512ed48 and b914084007" while queueing.
I noticed that I was missing a word in the message, and I'm sending a new patch with a better commit message for the second commit, so I'll update this in the first commit and send a new patchset.
> > A test would be nice, but I don't think it's very feasible for the same > > reason mentioned in 46df6906f3.
Yeah, I don't think I have a good enough grasp of how to test this, and I saw that there wasn't any existing tests for it, so that's why I dropped it.
-- Trygve Aaberge