[PATCH 2/2] Wait for child on signal death for aliases to externals

From: trygveaa@gmail.com <trygveaa@gmail.com>
Date: Jul 4, 2020, 22:18 UTC
Message-ID: <20200704221839.421997-2-trygveaa@gmail.com>
In-Reply-To: <20200704221839.421997-1-trygveaa@gmail.com>

From: Trygve Aaberge <trygveaa@gmail.com>

The previous commit fixed this only for aliases to builtins, this commit does the same for aliases to external commands. While the previous commit fixed a regression, I don't think this has ever worked properly.

Signed-off-by: Trygve Aaberge <trygveaa@gmail.com>
---

I can't say for sure if this will have any unintended side effects, so if someone with more knowledge about it can check/verify it, that would be great.

 git.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/git.c b/git.c
index c8336773e3..0797ac6a80 100644
--- a/git.c
+++ b/git.c
@@ -346,6 +346,8 @@ static int handle_alias(int *argcp, const char ***argv)
 			commit_pager_choice();
 
 			child.use_shell = 1;
+			child.clean_on_exit = 1;
+			child.wait_after_clean = 1;
 			child.trace2_child_class = "shell_alias";
 			argv_array_push(&child.args, alias_string + 1);
 			argv_array_pushv(&child.args, (*argv) + 1);

-- 
2.27.0