git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] Wait for child on signal death for aliases to builtins

From
Jeff King <peff@peff.net>
Date
Jul 6, 2020, 20:41 UTC
Message-ID
<20200706204106.GA85133@coredump.intra.peff.net>
In-Reply-To
<20200704221839.421997-1-trygveaa@gmail.com>
On Sun, Jul 05, 2020 at 12:18:37AM +0200, trygveaa@gmail.com wrote:
Show 10 quoted lines
> From: Trygve Aaberge <trygveaa@gmail.com>
> 
> When you hit ^C all the processes in the tree receives it. When a git
> command uses a pager, git ignores this and waits until the pager quits.
> However, when using an alias there is an additional process in the tree
> which didn't ignore the signal. That caused it to exit which in turn
> caused the pager to exit. This fixes that for aliases to builtins.
> 
> This was originally fixed in 46df6906f3 (see that for a more in
> explanation), but broke by a regression in b914084007.

Good catch. The regression is technically in b914084007, but the real culprit is the extra (commented out) code path added in ee4512ed48 (trace2: create new combined trace facility, 2019-02-22).

Your fix here looks good, but it does make me wonder if we could avoid or shrink this duplicate code path. I.e., could it just do the logging necessary but still leave the actual process spawn to the execv_dashed_external() below. It may be hard to untangle, though, so certainly this makes sense in the meantime.

A test would be nice, but I don't think it's very feasible for the same reason mentioned in 46df6906f3.

-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 9 of 13 in “Wait for child on signal death for aliases to builtins”
  1. 1/2 Wait for child on signal death for aliases to builtinstrygveaa@gmail.com, Jul 4, 2020
  2. 2/2 Wait for child on signal death for aliases to externalstrygveaa@gmail.com, Jul 4, 2020
  3. Jeff KingJul 6, 2020
  4. Junio C HamanoJul 7, 2020
  5. Trygve AabergeJul 7, 2020
  6. Jeff KingJul 7, 2020
  7. Johannes SchindelinJul 5, 2020
  8. Junio C HamanoJul 7, 2020
  9. Jeff KingJul 6, 2020
  10. Junio C HamanoJul 7, 2020
  11. Trygve AabergeJul 7, 2020
  12. 1/2 Wait for child on signal death for aliases to builtinstrygveaa@gmail.com, Jul 7, 2020
  13. 2/2 Wait for child on signal death for aliases to externalstrygveaa@gmail.com, Jul 7, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.