git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Makefile: remove an out-of-date comment

From
Jeff King <peff@peff.net>
Date
Feb 22, 2019, 15:09 UTC
Message-ID
<20190222150946.GC5090@sigill.intra.peff.net>
In-Reply-To
<20190222105658.26831-1-avarab@gmail.com>
On Fri, Feb 22, 2019 at 11:56:58AM +0100, Ævar Arnfjörð Bjarmason wrote:
Show 11 quoted lines
> Remove a comment referring to a caveat that hasn't been applicable
> since 18b0fc1ce1 ("Git.pm: Kill Git.xs for now", 2006-09-23).
> 
> At the time of 8d7f586f13 ("Git.pm: Support for perl/ being built by a
> different compiler", 2006-06-25) some of the code in perl would be
> built by a C compiler, but support for that went away a few months
> later in 18b0fc1ce1 discussed above.
> 
> Since my 20d2a30f8f ("Makefile: replace perl/Makefile.PL with simple
> make rules", 2017-12-10) the perl/ directory doesn't even have its own
> build process.

I liked that commit before, but seeing that it makes this hairy corner case go away, I like it even more. ;)

The patch itself seems obviously correct.
-Peff
Previous: Junio C Hamano
Message 20 of 20 in “Makefile: remove an out-of-date comment”
  1. Makefile: remove an out-of-date commentÆvar Arnfjörð Bjarmason, Feb 22, 2019
  2. 0/6 Makefile: allow for combining DEVELOPER= and CFLAGS="..."Ævar Arnfjörð Bjarmason, Feb 22, 2019
  3. Jeff KingFeb 22, 2019
  4. Ævar Arnfjörð BjarmasonFeb 22, 2019
  5. Jeff KingFeb 23, 2019
  6. 1/6 Makefile: remove an out-of-date commentÆvar Arnfjörð Bjarmason, Feb 22, 2019
  7. 2/6 Makefile: move "strip" assignment down from flagsÆvar Arnfjörð Bjarmason, Feb 22, 2019
  8. Jeff KingFeb 22, 2019
  9. Ramsay JonesFeb 22, 2019
  10. Jeff KingFeb 23, 2019
  11. 3/6 Makefile: add/remove comments at top and tweak whitespaceÆvar Arnfjörð Bjarmason, Feb 22, 2019
  12. 4/6 Makefile: Move *_LIBS assignment into its own sectionÆvar Arnfjörð Bjarmason, Feb 22, 2019
  13. Jeff KingFeb 22, 2019
  14. Eric SunshineFeb 22, 2019
  15. 5/6 Makefile: move the setting of *FLAGS closer to "include"Ævar Arnfjörð Bjarmason, Feb 22, 2019
  16. Junio C HamanoFeb 22, 2019
  17. 6/6 Makefile: allow for combining DEVELOPER=1 and CFLAGS="..."Ævar Arnfjörð Bjarmason, Feb 22, 2019
  18. Jeff KingFeb 22, 2019
  19. Junio C HamanoFeb 22, 2019
  20. Jeff KingFeb 22, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.