git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/6] Makefile: allow for combining DEVELOPER= and CFLAGS="..."

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Feb 22, 2019, 14:41 UTC
Message-ID
<20190222144127.32248-1-avarab@gmail.com>
In-Reply-To
<20190222105658.26831-1-avarab@gmail.com>

This fixes a long-standing annoyance of mine of not being able to set my own CFLAGS combined with DEVELOPER="...".

There *should* be no other functional changes, but I'm moving around some core Makefile logic, so this needs to be carefully reviewed.

I've tried installing with this, setting flags involved etc. It works as expected, but we have no tests for the Makefile itself, so I might have missed something.

I sent a stand-alone "Makefile: remove an out-of-date comment"[1] a bit too soon as it turns out. I thought it could be stand-alone, but as it turns out I needed to move some code adjacent to it. It would conflict with this, so it's now bundled up with it as a v2.

1. https://public-inbox.org/git/20190222105658.26831-1-avarab@gmail.com/
Ævar Arnfjörð Bjarmason (6):
  Makefile: remove an out-of-date comment
  Makefile: move "strip" assignment down from flags
  Makefile: add/remove comments at top and tweak whitespace
  Makefile: Move *_LIBS assignment into its own section
  Makefile: move the setting of *FLAGS closer to "include"
  Makefile: allow for combining DEVELOPER=1 and CFLAGS="..."
 Makefile       | 63 ++++++++++++++++++++++++++------------------------
 config.mak.dev | 44 +++++++++++++++++------------------
 2 files changed, 55 insertions(+), 52 deletions(-)
-- 
2.21.0.rc2.1.g2d5e20a900.dirty
Previous: Ævar Arnfjörð BjarmasonNext: Jeff King
Message 2 of 20 in “Makefile: remove an out-of-date comment”
  1. Makefile: remove an out-of-date commentÆvar Arnfjörð Bjarmason, Feb 22, 2019
  2. 0/6 Makefile: allow for combining DEVELOPER= and CFLAGS="..."Ævar Arnfjörð Bjarmason, Feb 22, 2019
  3. Jeff KingFeb 22, 2019
  4. Ævar Arnfjörð BjarmasonFeb 22, 2019
  5. Jeff KingFeb 23, 2019
  6. 1/6 Makefile: remove an out-of-date commentÆvar Arnfjörð Bjarmason, Feb 22, 2019
  7. 2/6 Makefile: move "strip" assignment down from flagsÆvar Arnfjörð Bjarmason, Feb 22, 2019
  8. Jeff KingFeb 22, 2019
  9. Ramsay JonesFeb 22, 2019
  10. Jeff KingFeb 23, 2019
  11. 3/6 Makefile: add/remove comments at top and tweak whitespaceÆvar Arnfjörð Bjarmason, Feb 22, 2019
  12. 4/6 Makefile: Move *_LIBS assignment into its own sectionÆvar Arnfjörð Bjarmason, Feb 22, 2019
  13. Jeff KingFeb 22, 2019
  14. Eric SunshineFeb 22, 2019
  15. 5/6 Makefile: move the setting of *FLAGS closer to "include"Ævar Arnfjörð Bjarmason, Feb 22, 2019
  16. Junio C HamanoFeb 22, 2019
  17. 6/6 Makefile: allow for combining DEVELOPER=1 and CFLAGS="..."Ævar Arnfjörð Bjarmason, Feb 22, 2019
  18. Jeff KingFeb 22, 2019
  19. Junio C HamanoFeb 22, 2019
  20. Jeff KingFeb 22, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.