Re: [PATCH v2 0/6] Makefile: allow for combining DEVELOPER= and CFLAGS="..."

From: Jeff King <peff@peff.net>
Date: Feb 23, 2019, 13:22 UTC
Message-ID: <20190223132245.GA22403@sigill.intra.peff.net>
In-Reply-To: <87zhqn4h8n.fsf@evledraar.gmail.com>

On Fri, Feb 22, 2019 at 10:59:20PM +0100, Ævar Arnfjörð Bjarmason wrote:

Show 5 quoted lines

> > My personal complaint is that you cannot override DEVELOPER flags via
> > config.mak, because of the ordering. But it looks like your patch 6
> > specifically addresses that (yay!).
> 
> Do you mean DEVOPTS? That works for me.

No, I meant overriding a developer CFLAG with a later one on the command line. I.e., putting this in your config.mak:

  DEVELOPER = 1
  CFLAGS += -Wno-foo

doesn't work, because the user CFLAGS comes first. Your patch 6 does the right thing.

-Peff