From: Jeff King Date: Fri, 22 Feb 2019 15:09:46 GMT Subject: Re: [PATCH] Makefile: remove an out-of-date comment Message-ID: <20190222150946.GC5090@sigill.intra.peff.net> In-Reply-To: <20190222105658.26831-1-avarab@gmail.com> On Fri, Feb 22, 2019 at 11:56:58AM +0100, Ævar Arnfjörð Bjarmason wrote: > Remove a comment referring to a caveat that hasn't been applicable > since 18b0fc1ce1 ("Git.pm: Kill Git.xs for now", 2006-09-23). > > At the time of 8d7f586f13 ("Git.pm: Support for perl/ being built by a > different compiler", 2006-06-25) some of the code in perl would be > built by a C compiler, but support for that went away a few months > later in 18b0fc1ce1 discussed above. > > Since my 20d2a30f8f ("Makefile: replace perl/Makefile.PL with simple > make rules", 2017-12-10) the perl/ directory doesn't even have its own > build process. I liked that commit before, but seeing that it makes this hairy corner case go away, I like it even more. ;) The patch itself seems obviously correct. -Peff