git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 3/6] Makefile: add/remove comments at top and tweak whitespace

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Feb 22, 2019, 14:41 UTC
Message-ID
<20190222144127.32248-4-avarab@gmail.com>
In-Reply-To
<20190222105658.26831-1-avarab@gmail.com>

The top of the Makfile is mostly separated into logical steps like set default configuration, set programs etc., but there's some deviation from that.

Let's add mostly comments where they're missing, remove those that don't add anything. The whitespace tweaking makes subsequent patches smaller.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 Makefile | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/Makefile b/Makefile
index c53727e44b..0870fd4651 100644
--- a/Makefile
+++ b/Makefile
@@ -507,15 +507,14 @@ GIT-VERSION-FILE: FORCE
 -include GIT-VERSION-FILE
 
 # CFLAGS and LDFLAGS are for the users to override from the command line.
-
 CFLAGS = -g -O2 -Wall
 LDFLAGS =
 ALL_CFLAGS = $(CPPFLAGS) $(CFLAGS)
 ALL_LDFLAGS = $(LDFLAGS)
-
-# Create as necessary, replace existing, make ranlib unneeded.
 ARFLAGS = rcs
 
+# Set our default configuration.
+#
 # Among the variables below, these:
 #   gitexecdir
 #   template_dir
@@ -560,6 +559,7 @@ perllibdir_relative = $(patsubst $(prefix)/%,%,$(perllibdir))
 
 export prefix bindir sharedir sysconfdir gitwebdir perllibdir localedir
 
+# Set our default programs
 CC = cc
 AR = ar
 RM = rm -f
@@ -587,10 +587,6 @@ SP_EXTRA_FLAGS =
 
 SPATCH_FLAGS = --all-includes --patch .
 
-
-
-### --- END CONFIGURATION SECTION ---
-
 BASIC_CFLAGS = -I.
 BASIC_LDFLAGS =
 
-- 
2.21.0.rc2.1.g2d5e20a900.dirty
Previous: Jeff KingNext: Ævar Arnfjörð Bjarmason
Message 11 of 20 in “Makefile: remove an out-of-date comment”
  1. Makefile: remove an out-of-date commentÆvar Arnfjörð Bjarmason, Feb 22, 2019
  2. 0/6 Makefile: allow for combining DEVELOPER= and CFLAGS="..."Ævar Arnfjörð Bjarmason, Feb 22, 2019
  3. Jeff KingFeb 22, 2019
  4. Ævar Arnfjörð BjarmasonFeb 22, 2019
  5. Jeff KingFeb 23, 2019
  6. 1/6 Makefile: remove an out-of-date commentÆvar Arnfjörð Bjarmason, Feb 22, 2019
  7. 2/6 Makefile: move "strip" assignment down from flagsÆvar Arnfjörð Bjarmason, Feb 22, 2019
  8. Jeff KingFeb 22, 2019
  9. Ramsay JonesFeb 22, 2019
  10. Jeff KingFeb 23, 2019
  11. 3/6 Makefile: add/remove comments at top and tweak whitespaceÆvar Arnfjörð Bjarmason, Feb 22, 2019
  12. 4/6 Makefile: Move *_LIBS assignment into its own sectionÆvar Arnfjörð Bjarmason, Feb 22, 2019
  13. Jeff KingFeb 22, 2019
  14. Eric SunshineFeb 22, 2019
  15. 5/6 Makefile: move the setting of *FLAGS closer to "include"Ævar Arnfjörð Bjarmason, Feb 22, 2019
  16. Junio C HamanoFeb 22, 2019
  17. 6/6 Makefile: allow for combining DEVELOPER=1 and CFLAGS="..."Ævar Arnfjörð Bjarmason, Feb 22, 2019
  18. Jeff KingFeb 22, 2019
  19. Junio C HamanoFeb 22, 2019
  20. Jeff KingFeb 22, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.