Re: [PATCH v6 10/12] fsmonitor: add test cases for fsmonitor extension

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sep 19, 2017, 20:34 UTC
Message-ID: <20170919203408.GE75068@aiede.mtv.corp.google.com>
In-Reply-To: <2f3cdc85-f051-c0ae-b9db-fd13cac78aed@gmail.com>

Ben Peart wrote:

Show 8 quoted lines

> Some stats on these same coding style errors in the current bash scripts:
>
> 298 instances of "[a-z]\(\).*\{" ie "function_name() {" (no space)
> 140 instances of "if \[ .* \]" (not using the preferred "test")
> 293 instances of "if .*; then"
>
> Wouldn't it be great not to have to write up style feedback for when
> these all get copy/pasted into new scripts?

Agreed. Care to write patches for these? :) (I think three patches, one for each issue, would do the trick.)

Thanks, Jonathan

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.