From: Jonathan Nieder <jrnieder@gmail.com>
Date: Tue, 19 Sep 2017 20:34:08 GMT
Subject: Re: [PATCH v6 10/12] fsmonitor: add test cases for fsmonitor extension
Message-ID: <20170919203408.GE75068@aiede.mtv.corp.google.com>
In-Reply-To: <2f3cdc85-f051-c0ae-b9db-fd13cac78aed@gmail.com>

Ben Peart wrote:

> Some stats on these same coding style errors in the current bash scripts:
>
> 298 instances of "[a-z]\(\).*\{" ie "function_name() {" (no space)
> 140 instances of "if \[ .* \]" (not using the preferred "test")
> 293 instances of "if .*; then"
>
> Wouldn't it be great not to have to write up style feedback for when
> these all get copy/pasted into new scripts?

Agreed.  Care to write patches for these? :)  (I think three patches,
one for each issue, would do the trick.)

Thanks,
Jonathan