RE: [PATCH v6 12/12] fsmonitor: add a performance test
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Sep 19, 2017, 15:28 UTC
- Message-ID
- <alpine.DEB.2.21.1.1709191726430.219280@virtualbox>
- In-Reply-To
- <MWHPR21MB04789C11E37F58FF9BC11C51F4630@MWHPR21MB0478.namprd21.prod.outlook.com>
Hi Ben,
On Mon, 18 Sep 2017, Ben Peart wrote:
Show 20 quoted lines
> > From: Johannes Schindelin [mailto:Johannes.Schindelin@gmx.de]
> > On Fri, 15 Sep 2017, Ben Peart wrote:
> >
> > > + DWORD(WINAPI *NtSetSystemInformation)(INT, PVOID, ULONG) =
> > > + (DWORD(WINAPI *)(INT, PVOID,
> > ULONG))GetProcAddress(ntdll, "NtSetSystemInformation");
> > > + if (!NtSetSystemInformation)
> > > + return error("Can't get function addresses, wrong Windows
> > > +version?");
> >
> > It turns out that we have seen this plenty of times in Git for Windows'
> > fork, so much so that we came up with a nice helper to make this all a bit
> > more robust and a bit more obvious, too: the DECLARE_PROC_ADDR and
> > INIT_PROC_ADDR helpers in compat/win32/lazyload.h.
> >
> > Maybe this would be the perfect excuse to integrate this patch into upstream
> > Git?
>
> This patch is pretty hefty already. How about you push this capability
> upstream and I take advantage of it in a later patch. :)Deal: https://public-inbox.org/git/f5a3add27206df3e7f39efeac8a3c3b47f2b79f2.1505834586.git.johannes.schindelin@gmx.de
Ciao, Johannes