RE: [PATCH v6 10/12] fsmonitor: add test cases for fsmonitor extension

From: David Turner <david.turner@twosigma.com>
Date: Sep 15, 2017, 22:00 UTC
Message-ID: <dc1506689d3d4639b56f0489e4219054@exmbdft7.ad.twosigma.com>
In-Reply-To: <20170915192043.4516-11-benpeart@microsoft.com>

Show 11 quoted lines

> -----Original Message-----
> +dirty_repo () {
> +	: >untracked &&
> +	: >dir1/untracked &&
> +	: >dir2/untracked &&
> +	echo 1 >modified &&
> +	echo 2 >dir1/modified &&
> +	echo 3 >dir2/modified &&
> +	echo 4 >new &&
> +	echo 5 >dir1/new &&
> +	echo 6 >dir2/new

If I add an untracked file named dir3/untracked to dirty_repo
 (and write_integration_script), then "status doesn't detect 
unreported modifications", below, fails.  Did I do something 
wrong, or does this turn up a bug?

> +	test_expect_success "setup preloadIndex to $preload_val" '
> +		git config core.preloadIndex $preload_val &&
> +		if [ $preload_val -eq true ]

"-eq" is for numeric equality in POSIX shell. So this works if your /bin/sh is bash but not if it's e.g. dash. This happens twice more below. Use "=" instead.