git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/4] config.h

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Jun 13, 2017, 01:07 UTC
Message-ID
<20170613010747.GC133952@aiede.mtv.corp.google.com>
In-Reply-To
<20170612213406.83247-1-bmwill@google.com>
Brandon Williams wrote:
Show 5 quoted lines
> Brandon Williams (4):
>   config: create config.h
>   config: remove git_config_iter
>   config: don't include config.h by default
>   config: don't implicitly use gitdir
Patches 1-3 are
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
I'm very happy to see cache.h getting shorter and less intimidating.

I have some minor concerns with patch 4 that I described in a reply to that patch. I'd expect that after another round that one will be ready.

Thanks for a pleasant read.

Sincerely, Jonathan

Previous: Brandon WilliamsNext: Brandon Williams
Message 25 of 57 in “config.h”
  1. 0/4 config.hBrandon Williams, Jun 12, 2017
  2. 1/4 config: create config.hBrandon Williams, Jun 12, 2017
  3. 2/4 config: remove git_config_iterBrandon Williams, Jun 12, 2017
  4. Jonathan NiederJun 13, 2017
  5. Jeff KingJun 13, 2017
  6. 4/4 config: don't implicitly use gitdirBrandon Williams, Jun 12, 2017
  7. Jonathan NiederJun 13, 2017
  8. Brandon WilliamsJun 13, 2017
  9. Jonathan NiederJun 13, 2017
  10. Jonathan NiederJun 13, 2017
  11. Jeff KingJun 13, 2017
  12. Brandon WilliamsJun 13, 2017
  13. Jeff KingJun 13, 2017
  14. Jeff KingJun 13, 2017
  15. Brandon WilliamsJun 13, 2017
  16. Jonathan NiederJun 13, 2017
  17. Brandon WilliamsJun 13, 2017
  18. Jeff KingJun 13, 2017
  19. Brandon WilliamsJun 13, 2017
  20. 3/4 config: don't include config.h by defaultBrandon Williams, Jun 12, 2017
  21. Jeff KingJun 12, 2017
  22. Brandon WilliamsJun 12, 2017
  23. Jeff KingJun 12, 2017
  24. Brandon WilliamsJun 12, 2017
  25. Jonathan NiederJun 13, 2017
  26. 0/6 config.hBrandon Williams, Jun 13, 2017
  27. 1/6 config: create config.hBrandon Williams, Jun 13, 2017
  28. Jonathan NiederJun 13, 2017
  29. 2/6 config: remove git_config_iterBrandon Williams, Jun 13, 2017
  30. Jonathan NiederJun 13, 2017
  31. 5/6 setup: teach discover_git_directory to respect the commondirBrandon Williams, Jun 13, 2017
  32. Jeff KingJun 14, 2017
  33. Brandon WilliamsJun 14, 2017
  34. 6/6 config: respect commondirBrandon Williams, Jun 13, 2017
  35. 4/6 config: don't implicitly use gitdirBrandon Williams, Jun 13, 2017
  36. Jonathan NiederJun 13, 2017
  37. Brandon WilliamsJun 13, 2017
  38. Jonathan NiederJun 13, 2017
  39. Junio C HamanoJun 13, 2017
  40. Jonathan NiederJun 13, 2017
  41. Jacob KellerJun 14, 2017
  42. Jeff KingJun 14, 2017
  43. Brandon WilliamsJun 14, 2017
  44. 3/6 config: don't include config.h by defaultBrandon Williams, Jun 13, 2017
  45. Jonathan NiederJun 13, 2017
  46. 0/6 config.hBrandon Williams, Jun 14, 2017
  47. 1/6 config: create config.hBrandon Williams, Jun 14, 2017
  48. 2/6 config: remove git_config_iterBrandon Williams, Jun 14, 2017
  49. 4/6 setup: teach discover_git_directory to respect the commondirBrandon Williams, Jun 14, 2017
  50. 3/6 config: don't include config.h by defaultBrandon Williams, Jun 14, 2017
  51. 5/6 config: respect commondirBrandon Williams, Jun 14, 2017
  52. 6/6 config: don't implicitly use gitdir or commondirBrandon Williams, Jun 14, 2017
  53. Junio C HamanoJun 15, 2017
  54. Brandon WilliamsJun 15, 2017
  55. Junio C HamanoJun 15, 2017
  56. Brandon WilliamsJun 15, 2017
  57. Brandon WilliamsJun 16, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.