Re: [PATCH 2/4] config: remove git_config_iter

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jun 13, 2017, 00:49 UTC
Message-ID: <20170613004911.GA133952@aiede.mtv.corp.google.com>
In-Reply-To: <20170612213406.83247-3-bmwill@google.com>

(+tanayabh) Hi,

Brandon Williams wrote:

Show 7 quoted lines

> Since there is no implementation of the function 'git_config_iter' lets
> stop exporting it and remove the prototype from config.h.
>
> Signed-off-by: Brandon Williams <bmwill@google.com>
> ---
>  config.h | 1 -
>  1 file changed, 1 deletion(-)

Good eyes.  Looks like the function never existed.

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Show 12 quoted lines

> diff --git a/config.h b/config.h
> index f7f8b66c5..c70599bd5 100644
> --- a/config.h
> +++ b/config.h
> @@ -165,7 +165,6 @@ extern int git_configset_get_pathname(struct config_set *cs, const char *key, co
>  extern int git_config_get_value(const char *key, const char **value);
>  extern const struct string_list *git_config_get_value_multi(const char *key);
>  extern void git_config_clear(void);
> -extern void git_config_iter(config_fn_t fn, void *data);
>  extern int git_config_get_string_const(const char *key, const char **dest);
>  extern int git_config_get_string(const char *key, char **dest);
>  extern int git_config_get_int(const char *key, int *dest);