From: Jonathan Nieder <jrnieder@gmail.com>
Date: Tue, 13 Jun 2017 01:07:47 GMT
Subject: Re: [PATCH 0/4] config.h
Message-ID: <20170613010747.GC133952@aiede.mtv.corp.google.com>
In-Reply-To: <20170612213406.83247-1-bmwill@google.com>

Brandon Williams wrote:

> Brandon Williams (4):
>   config: create config.h
>   config: remove git_config_iter
>   config: don't include config.h by default
>   config: don't implicitly use gitdir

Patches 1-3 are

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

I'm very happy to see cache.h getting shorter and less intimidating.

I have some minor concerns with patch 4 that I described in a reply to
that patch.  I'd expect that after another round that one will be
ready.

Thanks for a pleasant read.

Sincerely,
Jonathan