Re: [PATCH v2 1/6] config: create config.h

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jun 13, 2017, 21:13 UTC
Message-ID: <20170613211305.GK133952@aiede.mtv.corp.google.com>
In-Reply-To: <20170613210321.152978-2-bmwill@google.com>

Hi,

Brandon Williams wrote:

Show 10 quoted lines

> Move all config related declarations from cache.h to a new config.h
> header file.  This makes cache.h smaller and allows for the opportunity
> in a following patch to only include config.h when needed.
>
> Signed-off-by: Brandon Williams <bmwill@google.com>
> ---
>  cache.h  | 190 +------------------------------------------------------------
>  config.h | 194 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 195 insertions(+), 189 deletions(-)
>  create mode 100644 config.h

'git diff HEAD^:cache.h config.h' confirms that this is straightforward code movement and didn't introduce any unintentional changes along the way. Thanks for writing it.

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>