Re: [PATCH 1/2] pack-objects: Teach --use-bitmap-index codepath to respect --local, --honor-pack-keep and --incremental

From: Jeff King <peff@peff.net>
Date: Aug 8, 2016, 19:09 UTC
Message-ID: <20160808190950.x7ld2r4n7id57nof@sigill.intra.peff.net>
In-Reply-To: <xmqqpopjdqsa.fsf@gitster.mtv.corp.google.com>

On Mon, Aug 08, 2016 at 12:06:13PM -0700, Junio C Hamano wrote:

Show 18 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> >> +	if grep -qFf nonlocal-loose 1.objects; then
> >> +		echo "Non-local object present in pack generated with --local"
> >> +		return 1
> >> +	fi
> >> +'
> >
> > grep -f isn't portable. However, I think:
> >
> >   echo $objsha1 >expect &&
> >   git show-index <1.pack | cut -d' ' -f2 >actual
> >   test_cmp expect actual
> >
> > would work (if you do stick with two entries, you might need to sort
> > your "expect").
> 
> Hmph, are you sure?  "grep -f pattern_file" is in POSIX.1.

Hmm, you're right. I specifically checked my local grep.1posix manpage, but searching for "-f" didn't turn up anything, because it's formatted with a Unicode minus sign (U+2212). Bleh.

-Peff