Re: [PATCH] pack-objects: Use reachability bitmap index when generating non-stdout pack too

From: Jeff King <peff@peff.net>
Date: Jul 13, 2016, 08:30 UTC
Message-ID: <20160713083044.GB18144@sigill.intra.peff.net>
In-Reply-To: <20160712190807.GB4809@teco.navytux.spb.ru>

On Tue, Jul 12, 2016 at 10:08:08PM +0300, Kirill Smelkov wrote:

Show 8 quoted lines

> > Or are we fine with my arguments about recency order staying the same
> > when using bitmap reachability index for object graph traversal, and this
> > way the patch is fine to go in as it is?
> 
> Since there is no reply I assume the safe way to go is to let default
> for pack-to-file case to be "not using bitmap index". Please find updated
> patch and interdiff below. I would still be grateful for feedback on
> my above use-bitmap-for-pack-to-file arguments.

Yeah, I think that is a reasonable approach. I see here you've added new config, though, and I don't think we want that.

For your purposes, where you're driving pack-objects individually, I think a command-line option makes more sense.

If we did want to have a flag for "use bitmaps when repacking via repack", I think it should be "repack.useBitmaps", and git-repack should pass the command-line option to pack-objects. pack-objects is porcelain and should not really be reading config at all. You'll note that pack.writeBitmaps was a mistake and got deprecated in favor of repack.writeBitmaps. I think pack.useBitmaps is a mistake, too, but nobody has really noticed or cared because there's no good reason to set it (the more interesting question is: are there bitmaps available? and if so, we try to use them).

-Peff