Re: [PATCH v4 2/2] pack-objects: Teach it to use reachability bitmap index when generating non-stdout pack too

From: Kirill Smelkov <kirr@nexedi.com>
Date: Aug 8, 2016, 18:13 UTC
Message-ID: <20160808181353.GC3995@teco.navytux.spb.ru>
In-Reply-To: <xmqq60rbf80t.fsf@gitster.mtv.corp.google.com>

On Mon, Aug 08, 2016 at 11:08:34AM -0700, Junio C Hamano wrote:

Show 21 quoted lines

> Kirill Smelkov <kirr@nexedi.com> writes:
> 
> > Thanks for the info. I did not knew about show-index when I was starting
> > to work on this and later it just came out of sight. Please find
> > corrected patch below.
> >
> > ---- 8< ----
> > From: Kirill Smelkov <kirr@nexedi.com>
> > Date: Fri, 29 Jul 2016 10:47:46 +0300
> > Subject: [PATCH v5] pack-objects: Teach it to use reachability bitmap index when
> >  generating non-stdout pack too
> 
> Please don't do this (not the patch text itself, but saying "Please
> find ..." and attaching the patch AFTER 60+ lines of response).
> When going through old/read messages to see if there are patches
> that fell through the cracks, if it is not immediately clear in the
> top part of the message that it contains an updated patch, such a
> patch will certainly be missed.
> 
> Please say "I'll follow up with a corrected patch" instead of
> "Please find ..." and respond to that message with just the patch.

Ok, I see. Should I resend this v5 as separated one or only starting from next time?

Another question: I'm preparing another version of "pack-objects: Teach --use-bitmap-index codepath to respect --local ..." and was going to put

    ( updated patch is in the end of this mail )

in the top of the message. Is it ok or better not to do so and just respin the patch in its own separate mail?

Thanks beforehand for clarifying, Kirill

P.S. I put updated patches in the same mail not because I'm trying to
    make maintainer's life harder, but because this is the way I would
    expect and prefer them to be coming to me...