git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 5/6] tag: use pgp_verify_function in tag -v call

From
Santiago Torres <santiago@nyu.edu>
Date
Apr 5, 2016, 01:43 UTC
Message-ID
<20160405014354.GA12006@LykOS>
In-Reply-To
<CAPig+cQkqaYd2Vpgpd5jB8ZUD41VvjryB8tYc9JNEydNaKrr=Q@mail.gmail.com>
On Mon, Apr 04, 2016 at 09:39:29PM -0400, Eric Sunshine wrote:
Show 10 quoted lines
> On Mon, Apr 4, 2016 at 6:22 PM,  <santiago@nyu.edu> wrote:
> > Instead of running the verify-tag plumbing command, we use the
> > pgp_verify_tag(). This avoids the usage of an extra fork call. To do
> > this, we extend the number of parameters that tag.c takes, and
> > verify-tag passes. Redundant calls done in the pgp_verify_tag function
> > are removed.
> 
> I'm confused about everything following "an extra fork call" since
> those subsequent sentences don't seem to pertain to this patch. Is
> that leftover gunk from the previous version of this series?

Yes, I thought I had taken this part of the commit message away. I'll take it out right away. Apologies for this.

-Santiago.
Previous: Eric SunshineNext: santiago@nyu.edu
Message 12 of 16 in “tag: move PGP verification code to tag.c”
  1. 0/6 tag: move PGP verification code to tag.csantiago@nyu.edu, Apr 4, 2016
  2. 1/6 builtin/verify-tag.c: Ignore SIGPIPE on gpg-interfacesantiago@nyu.edu, Apr 4, 2016
  3. 2/6 t/t7030-verify-tag.sh: Adds validation for multiple tagssantiago@nyu.edu, Apr 4, 2016
  4. Eric SunshineApr 5, 2016
  5. Santiago TorresApr 5, 2016
  6. Eric SunshineApr 5, 2016
  7. 3/6 builtin/verify-tag: move verification code to tag.csantiago@nyu.edu, Apr 4, 2016
  8. 4/6 tag.c: Replace varialbe name for readabilitysantiago@nyu.edu, Apr 4, 2016
  9. Eric SunshineApr 5, 2016
  10. 5/6 tag: use pgp_verify_function in tag -v callsantiago@nyu.edu, Apr 4, 2016
  11. Eric SunshineApr 5, 2016
  12. Santiago TorresApr 5, 2016
  13. 6/6 tag.c: Change gpg_verify_tag argument to sha1santiago@nyu.edu, Apr 4, 2016
  14. Eric SunshineApr 5, 2016
  15. Santiago TorresApr 5, 2016
  16. Eric SunshineApr 5, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.