git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 2/6] t/t7030-verify-tag.sh: Adds validation for multiple tags

From
Santiago Torres <santiago@nyu.edu>
Date
Apr 5, 2016, 01:46 UTC
Message-ID
<20160405014609.GB12006@LykOS>
In-Reply-To
<CAPig+cQJ6EzJ0976NJBHXRZyuTf1dr+0ZOvzrCfiTVZOp6fXBA@mail.gmail.com>
Show 10 quoted lines
> 
> The bulk of this description is merely repeating what the patch itself
> already says, thus is redundant. The entire commit message could
> probably be collapsed to:
> 
>     t7030: test verify-tag with multiple tags
> 
>     git-verify-tag accepts multiple tags as arguments, however,
>     existing tests only ever invoke it with a single tag, so add a
>     test invoking it with multiple tags.
Yeah, this is actually clearer. Sorry for the academ-ose commit message.
Show 14 quoted lines
> > +test_expect_success GPG 'verify multiple tags' '
> > +       tags="fourth-signed sixth-signed seventh-signed" &&
> > +       for i in $tags; do
> > +               git verify-tag -v --raw $i || return 1
> > +       done >expect.stdout 2>expect.stderr.1 &&
> > +       grep GOODSIG <expect.stderr.1 >expect.stderr &&
> > +       git verify-tag -v --raw $tags >actual.stdout 2>actual.stderr.1 &&
> > +       grep GOODSIG <actual.stderr.1 >actual.stderr &&
> 
> Hmm, I had expected you to adopt Peff's suggestion[1] for the greps:
> 
>     grep '^.GNUPG:.' ...
> 
> [1]: http://article.gmane.org/gmane.comp.version-control.git/290691

I thought this was an stylistic thing. I can of course adopt this suggestion.

Thanks, -Santiago

Previous: Eric SunshineNext: Eric Sunshine
Message 5 of 16 in “tag: move PGP verification code to tag.c”
  1. 0/6 tag: move PGP verification code to tag.csantiago@nyu.edu, Apr 4, 2016
  2. 1/6 builtin/verify-tag.c: Ignore SIGPIPE on gpg-interfacesantiago@nyu.edu, Apr 4, 2016
  3. 2/6 t/t7030-verify-tag.sh: Adds validation for multiple tagssantiago@nyu.edu, Apr 4, 2016
  4. Eric SunshineApr 5, 2016
  5. Santiago TorresApr 5, 2016
  6. Eric SunshineApr 5, 2016
  7. 3/6 builtin/verify-tag: move verification code to tag.csantiago@nyu.edu, Apr 4, 2016
  8. 4/6 tag.c: Replace varialbe name for readabilitysantiago@nyu.edu, Apr 4, 2016
  9. Eric SunshineApr 5, 2016
  10. 5/6 tag: use pgp_verify_function in tag -v callsantiago@nyu.edu, Apr 4, 2016
  11. Eric SunshineApr 5, 2016
  12. Santiago TorresApr 5, 2016
  13. 6/6 tag.c: Change gpg_verify_tag argument to sha1santiago@nyu.edu, Apr 4, 2016
  14. Eric SunshineApr 5, 2016
  15. Santiago TorresApr 5, 2016
  16. Eric SunshineApr 5, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.