Re: [PATCH v4 2/6] t/t7030-verify-tag.sh: Adds validation for multiple tags
- From
Santiago Torres <santiago@nyu.edu>
- Date
- Apr 5, 2016, 01:46 UTC
- Message-ID
- <20160405014609.GB12006@LykOS>
- In-Reply-To
- <CAPig+cQJ6EzJ0976NJBHXRZyuTf1dr+0ZOvzrCfiTVZOp6fXBA@mail.gmail.com>
Show 10 quoted lines
> > The bulk of this description is merely repeating what the patch itself > already says, thus is redundant. The entire commit message could > probably be collapsed to: > > t7030: test verify-tag with multiple tags > > git-verify-tag accepts multiple tags as arguments, however, > existing tests only ever invoke it with a single tag, so add a > test invoking it with multiple tags.
Yeah, this is actually clearer. Sorry for the academ-ose commit message.
Show 14 quoted lines
> > +test_expect_success GPG 'verify multiple tags' ' > > + tags="fourth-signed sixth-signed seventh-signed" && > > + for i in $tags; do > > + git verify-tag -v --raw $i || return 1 > > + done >expect.stdout 2>expect.stderr.1 && > > + grep GOODSIG <expect.stderr.1 >expect.stderr && > > + git verify-tag -v --raw $tags >actual.stdout 2>actual.stderr.1 && > > + grep GOODSIG <actual.stderr.1 >actual.stderr && > > Hmm, I had expected you to adopt Peff's suggestion[1] for the greps: > > grep '^.GNUPG:.' ... > > [1]: http://article.gmane.org/gmane.comp.version-control.git/290691
I thought this was an stylistic thing. I can of course adopt this suggestion.
Thanks, -Santiago