Re: [PATCH v4 2/6] t/t7030-verify-tag.sh: Adds validation for multiple tags

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Apr 5, 2016, 03:51 UTC
Message-ID: <CAPig+cTkQn45ax5pEGghj6_c=FKwP=ApxRo85Jyyu1UD28FrJA@mail.gmail.com>
In-Reply-To: <20160405014609.GB12006@LykOS>

On Mon, Apr 4, 2016 at 9:46 PM, Santiago Torres <santiago@nyu.edu> wrote:

Show 18 quoted lines

> Eric Sunshine wrote:
>> > +test_expect_success GPG 'verify multiple tags' '
>> > +       tags="fourth-signed sixth-signed seventh-signed" &&
>> > +       for i in $tags; do
>> > +               git verify-tag -v --raw $i || return 1
>> > +       done >expect.stdout 2>expect.stderr.1 &&
>> > +       grep GOODSIG <expect.stderr.1 >expect.stderr &&
>> > +       git verify-tag -v --raw $tags >actual.stdout 2>actual.stderr.1 &&
>> > +       grep GOODSIG <actual.stderr.1 >actual.stderr &&
>>
>> Hmm, I had expected you to adopt Peff's suggestion[1] for the greps:
>>
>>     grep '^.GNUPG:.' ...
>>
>> [1]: http://article.gmane.org/gmane.comp.version-control.git/290691
>
> I thought this was an stylistic thing. I can of course adopt this
> suggestion.

It's probably not a big deal, but Peff's suggestion (at least feels like it) makes the test a bit more comprehensive.

By the way, as the test is heavily inspired by Peff's example, it might be worth giving him a nod via a Helped-by: just above your Signed-off-by:.