git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv3 0/4] Some cleanups

From
Jeff King <peff@peff.net>
Date
Mar 31, 2016, 19:33 UTC
Message-ID
<20160331193333.GD5013@sigill.intra.peff.net>
In-Reply-To
<xmqqio02mokp.fsf@gitster.mtv.corp.google.com>
On Thu, Mar 31, 2016 at 12:31:34PM -0700, Junio C Hamano wrote:
Show 9 quoted lines
> Jeff King <peff@peff.net> writes:
> 
> > With the exception of the comments on patch 3, these all look good. I'll
> > leave it to Junio to decide whether he wants to polish up his "get rid
> > of strbuf_split" patch for patch 2. Certainly yours is a strict
> > improvement over what is there.
> 
> I do not think there were anything further to be polished up.  Other
> than that, I agree with all of the above.
Well, by polish up, I meant "write a commit message for". :)
The patch itself looked fine to me.
-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 12 of 13 in “[PATCHv3 0/4] Some cleanups”
  1. Stefan BellerMar 31, 2016
  2. 1/4 notes: don't leak memory in git_config_get_notes_strategyStefan Beller, Mar 31, 2016
  3. Eric SunshineMar 31, 2016
  4. Junio C HamanoMar 31, 2016
  5. Jeff KingMar 31, 2016
  6. 2/4 abbrev_sha1_in_line: don't leak memoryStefan Beller, Mar 31, 2016
  7. 3/4 bundle: don't leak an fd in case of early returnStefan Beller, Mar 31, 2016
  8. Jeff KingMar 31, 2016
  9. 4/4 credential-cache, send_request: close fd when doneStefan Beller, Mar 31, 2016
  10. Jeff KingMar 31, 2016
  11. Junio C HamanoMar 31, 2016
  12. Jeff KingMar 31, 2016
  13. Junio C HamanoMar 31, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.