git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv3 4/4] credential-cache, send_request: close fd when done

From
Stefan Beller <sbeller@google.com>
Date
Mar 31, 2016, 18:04 UTC
Message-ID
<1459447446-32260-5-git-send-email-sbeller@google.com>
In-Reply-To
<1459447446-32260-1-git-send-email-sbeller@google.com>
No need to keep it open any further.
Signed-off-by: Stefan Beller <sbeller@google.com>
---
 credential-cache.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/credential-cache.c b/credential-cache.c
index f4afdc6..86e21de 100644
--- a/credential-cache.c
+++ b/credential-cache.c
@@ -32,6 +32,7 @@ static int send_request(const char *socket, const struct strbuf *out)
 		write_or_die(1, in, r);
 		got_data = 1;
 	}
+	close(fd);
 	return got_data;
 }
 
-- 
2.5.0.264.g4004fdc.dirty
Previous: Jeff KingNext: Jeff King
Message 9 of 13 in “[PATCHv3 0/4] Some cleanups”
  1. Stefan BellerMar 31, 2016
  2. 1/4 notes: don't leak memory in git_config_get_notes_strategyStefan Beller, Mar 31, 2016
  3. Eric SunshineMar 31, 2016
  4. Junio C HamanoMar 31, 2016
  5. Jeff KingMar 31, 2016
  6. 2/4 abbrev_sha1_in_line: don't leak memoryStefan Beller, Mar 31, 2016
  7. 3/4 bundle: don't leak an fd in case of early returnStefan Beller, Mar 31, 2016
  8. Jeff KingMar 31, 2016
  9. 4/4 credential-cache, send_request: close fd when doneStefan Beller, Mar 31, 2016
  10. Jeff KingMar 31, 2016
  11. Junio C HamanoMar 31, 2016
  12. Jeff KingMar 31, 2016
  13. Junio C HamanoMar 31, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.