[PATCHv3 1/4] notes: don't leak memory in git_config_get_notes_strategy

From: Stefan Beller <sbeller@google.com>
Date: Mar 31, 2016, 18:04 UTC
Message-ID: <1459447446-32260-2-git-send-email-sbeller@google.com>
In-Reply-To: <1459447446-32260-1-git-send-email-sbeller@google.com>

`value` is just a temporary scratchpad, so we need to make sure it doesn't leak. It is xstrdup'd in `git_config_get_string_const` and `parse_notes_merge_strategy` just compares the string against predefined values, so no need to keep it around longer. Instead of using `git_config_get_string_const`, use `git_config_get_value`, which doesn't return a copy.

Signed-off-by: Stefan Beller <sbeller@google.com>
---
 builtin/notes.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/builtin/notes.c b/builtin/notes.c
index ed6f222..fa21f1a 100644
--- a/builtin/notes.c
+++ b/builtin/notes.c
@@ -746,7 +746,7 @@ static int git_config_get_notes_strategy(const char *key,
 {
 	const char *value;
 
-	if (git_config_get_string_const(key, &value))
+	if (git_config_get_value(key, &value))
 		return 1;
 	if (parse_notes_merge_strategy(value, strategy))
 		git_die_config(key, "unknown notes merge strategy %s", value);

-- 
2.5.0.264.g4004fdc.dirty