Re: [PATCHv3 0/4] Some cleanups

From: Jeff King <peff@peff.net>
Date: Mar 31, 2016, 19:12 UTC
Message-ID: <20160331191252.GB5013@sigill.intra.peff.net>
In-Reply-To: <1459447446-32260-1-git-send-email-sbeller@google.com>

On Thu, Mar 31, 2016 at 11:04:02AM -0700, Stefan Beller wrote:

Show 12 quoted lines

> v3:
> Thanks Eric, Jeff, Junio for discussion!
> * use git_config_get_value instead of git_config_get_string in patch 1
> * Improve commit message to explain why strbuf_list_free frees more memory
>   (hence is the right thing to do)
> * the bundle code doesn't have a dedicated return variable,
>   but the error path always returns -1  
> * removed a duplicate of
>         +	if (!bundle_to_stdout)
>         +		close(bundle_fd);
>   in the bundle patch.
> * This applies on v2.8.0.

With the exception of the comments on patch 3, these all look good. I'll leave it to Junio to decide whether he wants to polish up his "get rid of strbuf_split" patch for patch 2. Certainly yours is a strict improvement over what is there.

-Peff