From: Jeff King Date: Thu, 31 Mar 2016 19:33:33 GMT Subject: Re: [PATCHv3 0/4] Some cleanups Message-ID: <20160331193333.GD5013@sigill.intra.peff.net> In-Reply-To: On Thu, Mar 31, 2016 at 12:31:34PM -0700, Junio C Hamano wrote: > Jeff King writes: > > > With the exception of the comments on patch 3, these all look good. I'll > > leave it to Junio to decide whether he wants to polish up his "get rid > > of strbuf_split" patch for patch 2. Certainly yours is a strict > > improvement over what is there. > > I do not think there were anything further to be polished up. Other > than that, I agree with all of the above. Well, by polish up, I meant "write a commit message for". :) The patch itself looked fine to me. -Peff