Re: [PATCH v3 2/5] tree-walk.c: remove name_compare() function

From: Jeremiah Mahler <jmmahler@gmail.com>
Date: Jun 19, 2014, 08:04 UTC
Message-ID: <20140619080418.GA15698@hudson.localdomain>
In-Reply-To: <20140618190359.GS8557@google.com>

Jonathan,

On Wed, Jun 18, 2014 at 12:03:59PM -0700, Jonathan Nieder wrote:

Show 17 quoted lines

> Jeremiah Mahler wrote:
> 
> > Remove the duplicate name_compare() function and use the one provided by
> > read-cache.c.
> 
> I'd squash this into patch 1/5.
> 
> > ---
> > Notes:
> >     There is one small difference between the old function and the new one.
> >     The old one returned -N and +N whereas the new one returns -1 and +1.
> >     However, there is no place where the magnitude was needed, so this
> >     change will not alter its behavior.
> 
> This is useful information for anyone looking back at the patch in the
> future, so it belongs above the three-dash divider.
>

Makes sense. I will add it to the log message.

> Thanks,
> Jonathan

Thanks,

-- 
Jeremiah Mahler
jmmahler@gmail.com
http://github.com/jmahler