Re: [PATCH v3 0/5] cleanup duplicate name_compare() functions

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jun 18, 2014, 19:14 UTC
Message-ID: <20140618191407.GX8557@google.com>
In-Reply-To: <1403117117-10384-1-git-send-email-jmmahler@gmail.com>

Jeremiah Mahler wrote:

Show 14 quoted lines

> Jeremiah Mahler (5):
>   cache: rename cache_name_compare() to name_compare()
>   tree-walk.c: remove name_compare() function
>   unpack-trees.c: remove name_compare() function
>   dir.c: rename to name_compare()
>   name-hash.c: rename to name_compare()
>
>  cache.h        |  2 +-
>  dir.c          |  3 +--
>  name-hash.c    |  2 +-
>  read-cache.c   | 23 +++++++++++++----------
>  tree-walk.c    | 10 ----------
>  unpack-trees.c | 11 -----------
>  6 files changed, 16 insertions(+), 35 deletions(-)

After looking at the patches I suspect this should be a single patch. That way it's bisectable, and the changes outside of read-cache.c are small enough that it's not too much of a burden to review as a single patch.

The code change looked good.

Thanks and hope that helps, Jonathan