git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 4/5] dir.c: rename to name_compare()

From
Jeremiah Mahler <jmmahler@gmail.com>
Date
Jun 18, 2014, 18:45 UTC
Message-ID
<1403117117-10384-5-git-send-email-jmmahler@gmail.com>
In-Reply-To
<1403117117-10384-1-git-send-email-jmmahler@gmail.com>
Rename the call to cache_name_compare() to name_compare().
Signed-off-by: Jeremiah Mahler <jmmahler@gmail.com>
---
Notes:
    This is a case where cache_name_compare() was used even though it had
    nothing to do with a cache.  The new name makes it clear that no cache
    is involved.
 dir.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/dir.c b/dir.c
index 797805d..e65888d 100644
--- a/dir.c
+++ b/dir.c
@@ -1354,8 +1354,7 @@ static int cmp_name(const void *p1, const void *p2)
 	const struct dir_entry *e1 = *(const struct dir_entry **)p1;
 	const struct dir_entry *e2 = *(const struct dir_entry **)p2;
 
-	return cache_name_compare(e1->name, e1->len,
-				  e2->name, e2->len);
+	return name_compare(e1->name, e1->len, e2->name, e2->len);
 }
 
 static struct path_simplify *create_simplify(const char **pathspec)
-- 
2.0.0
Previous: Jonathan NiederNext: Jonathan Nieder
Message 9 of 15 in “cleanup duplicate name_compare() functions”
  1. 0/5 cleanup duplicate name_compare() functionsJeremiah Mahler, Jun 18, 2014
  2. 1/5 cache: rename cache_name_compare() to name_compare()Jeremiah Mahler, Jun 18, 2014
  3. Jonathan NiederJun 18, 2014
  4. 2/5 tree-walk.c: remove name_compare() functionJeremiah Mahler, Jun 18, 2014
  5. Jonathan NiederJun 18, 2014
  6. Jeremiah MahlerJun 19, 2014
  7. 3/5 unpack-trees.c: remove name_compare() functionJeremiah Mahler, Jun 18, 2014
  8. Jonathan NiederJun 18, 2014
  9. 4/5 dir.c: rename to name_compare()Jeremiah Mahler, Jun 18, 2014
  10. Jonathan NiederJun 18, 2014
  11. 5/5 name-hash.c: rename to name_compare()Jeremiah Mahler, Jun 18, 2014
  12. Jonathan NiederJun 18, 2014
  13. Jonathan NiederJun 18, 2014
  14. Jeremiah MahlerJun 19, 2014
  15. Jeff KingJun 19, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.