[PATCH v3 2/5] tree-walk.c: remove name_compare() function
- From
Jeremiah Mahler <jmmahler@gmail.com>
- Date
- Jun 18, 2014, 18:45 UTC
- Message-ID
- <1403117117-10384-3-git-send-email-jmmahler@gmail.com>
- In-Reply-To
- <1403117117-10384-1-git-send-email-jmmahler@gmail.com>
Remove the duplicate name_compare() function and use the one provided by read-cache.c.
Signed-off-by: Jeremiah Mahler <jmmahler@gmail.com> ---
Notes:
There is one small difference between the old function and the new one.
The old one returned -N and +N whereas the new one returns -1 and +1.
However, there is no place where the magnitude was needed, so this
change will not alter its behavior.tree-walk.c | 10 ---------- 1 file changed, 10 deletions(-)
diff --git a/tree-walk.c b/tree-walk.c index 4dc86c7..5dd9a71 100644 --- a/tree-walk.c +++ b/tree-walk.c @@ -144,16 +144,6 @@ struct tree_desc_x { struct tree_desc_skip *skip; }; -static int name_compare(const char *a, int a_len, - const char *b, int b_len) -{ - int len = (a_len < b_len) ? a_len : b_len; - int cmp = memcmp(a, b, len); - if (cmp) - return cmp; - return (a_len - b_len); -} - static int check_entry_match(const char *a, int a_len, const char *b, int b_len) { /*
-- 2.0.0