Re: [PATCH v2 2/4] commit-queue: LIFO or priority queue of commits
- From
Jeff King <peff@peff.net>
- Date
- Jun 10, 2013, 18:59 UTC
- Message-ID
- <20130610185907.GD2084@sigill.intra.peff.net>
- In-Reply-To
- <7v1u89iyla.fsf@alter.siamese.dyndns.org>
On Mon, Jun 10, 2013 at 11:56:33AM -0700, Junio C Hamano wrote:
Show 9 quoted lines
> > or similar. I didn't change the name, either. It may be silly to call it > > "commit_queue" still since it is now more general. I simply called mine > > "queue" (I wanted "pqueue", but that conflicted with globals defined by > > OpenSSL; yours is a more general queue anyway, so maybe that is a good > > name). > > I agree that it makes sense not to call it either commit-queue or > pqueue. While at it, the filenames should probably be moved as > well, no?
Yeah, definitely. I left all of that as an exercise for you, since the name change will involve a lot of fallout in the other patches.
-Peff