Re: [PATCH/RFC] rev-list: add --authorship-order alternative ordering

From: Jeff King <peff@peff.net>
Date: Jun 4, 2013, 21:22 UTC
Message-ID: <20130604212254.GC3271@sigill.intra.peff.net>
In-Reply-To: <7vip1t7koi.fsf@alter.siamese.dyndns.org>

On Tue, Jun 04, 2013 at 12:14:21PM -0700, Junio C Hamano wrote:

Show 13 quoted lines

> > diff --git a/commit.h b/commit.h
> > index 67bd509..de07525 100644
> > --- a/commit.h
> > +++ b/commit.h
> > @@ -17,6 +17,7 @@ struct commit {
> >  	void *util;
> >  	unsigned int indegree;
> >  	unsigned long date;
> > +	unsigned long author_date;
> 
> While walking we keep many of them in-core, and 8-byte each for each
> commit objects add up.  We do not want to make "struct commit" any
> larger than it already is.

Yeah, I had the same thought. Maybe this is a good candidate to build on top of the jk/commit-info slab experiment. The topo-sort could allocate an extra slab for author-date (or even expand the indegree slab to hold both indegree and author date), use it during the sort, and then free it afterwards.

Elliott: you can see the relevant changes to the topo-sort in commit
96c4f4a (commit: allow associating auxiliary info on-demand,
2013-04-09).

-Peff