Re: [PATCH v2 2/4] commit-queue: LIFO or priority queue of commits

From: Jeff King <peff@peff.net>
Date: Jun 11, 2013, 06:36 UTC
Message-ID: <20130611063648.GB23650@sigill.intra.peff.net>
In-Reply-To: <7vd2rteej0.fsf@alter.siamese.dyndns.org>

On Mon, Jun 10, 2013 at 04:23:31PM -0700, Junio C Hamano wrote:

Show 7 quoted lines

> OK, I pushed out a result of some renaming and rebasing.  Notable
> changes are:
> 
>  - The data and API is called prio-queue and they live in prio-queue.[ch];
> 
>  - The test script is also named test-prio-queue.c, to leave the
>    door open for other kinds of queue;

Sounds reasonable, though you may want to update the commit message of jc/topo-author-date-sort~2.

>  - For now, record_author_date() does the obvious read-sha1-file and
>    free; and

I think that is a good place to leave it in this series. It does not hurt performance in any existing cases, and any parsing refactoring can come later if somebody wants to work on it.

>  - The comparison callback's function signature had three "void *",
>    so they are named in the header file now.  Also two "thing"
>    pointers are marked as "const void *".

Yeah, I noticed both when porting my tests, but didn't want to add too many distracting details. Thanks for fixing.

Overall, it looks good for me except for the commit message tweaks I mentioned above.

-Peff