git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 3/3] branch: mark more strings for translation

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Jan 27, 2013, 11:55 UTC
Message-ID
<20130127115516.GD4228@elie.Belkin>
In-Reply-To
<1359118225-14356-3-git-send-email-pclouds@gmail.com>
Nguyễn Thái Ngọc Duy wrote:
Show 8 quoted lines
> --- a/builtin/branch.c
> +++ b/builtin/branch.c
> @@ -466,7 +466,7 @@ static void add_verbose_info(struct strbuf *out, struct ref_item *item,
>  			     int verbose, int abbrev)
>  {
>  	struct strbuf subject = STRBUF_INIT, stat = STRBUF_INIT;
> -	const char *sub = " **** invalid ref ****";
> +	const char *sub = _(" **** invalid ref ****");

This worried me for a second --- is it an actual message that gets emitted, a placeholder used only in code, or some combination of the two?

Luckily it really is just a message (or rather, a value for the commit message column in the " f7c0c00 [ahead 58, behind 197] vcs-svn: drop obj_pool.h" message).

For what it's worth, assuming this passes tests,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Previous: Nguyễn Thái Ngọc DuyNext: Junio C Hamano
Message 8 of 14 in “branch: reject -D/-d without branch name”
  1. branch: reject -D/-d without branch nameNguyễn Thái Ngọc Duy, Jan 25, 2013
  2. Matthieu MoyJan 25, 2013
  3. Duy NguyenJan 25, 2013
  4. 1/3 branch: reject -D/-d without branch nameNguyễn Thái Ngọc Duy, Jan 25, 2013
  5. 2/3 branch: give a more helpful message on redundant argumentsNguyễn Thái Ngọc Duy, Jan 25, 2013
  6. Jonathan NiederJan 27, 2013
  7. 3/3 branch: mark more strings for translationNguyễn Thái Ngọc Duy, Jan 25, 2013
  8. Jonathan NiederJan 27, 2013
  9. Junio C HamanoJan 25, 2013
  10. Duy NguyenJan 26, 2013
  11. 1/4 branch: no detached HEAD check when editing another branch's descriptionNguyễn Thái Ngọc Duy, Jan 28, 2013
  12. 2/4 branch: reject -D/-d without branch nameNguyễn Thái Ngọc Duy, Jan 28, 2013
  13. 3/4 branch: give a more helpful message on redundant argumentsNguyễn Thái Ngọc Duy, Jan 28, 2013
  14. 4/4 branch: mark more strings for translationNguyễn Thái Ngọc Duy, Jan 28, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.