From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sun, 27 Jan 2013 11:55:16 GMT
Subject: Re: [PATCH v2 3/3] branch: mark more strings for translation
Message-ID: <20130127115516.GD4228@elie.Belkin>
In-Reply-To: <1359118225-14356-3-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy wrote:

> --- a/builtin/branch.c
> +++ b/builtin/branch.c
> @@ -466,7 +466,7 @@ static void add_verbose_info(struct strbuf *out, struct ref_item *item,
>  			     int verbose, int abbrev)
>  {
>  	struct strbuf subject = STRBUF_INIT, stat = STRBUF_INIT;
> -	const char *sub = " **** invalid ref ****";
> +	const char *sub = _(" **** invalid ref ****");

This worried me for a second --- is it an actual message that gets
emitted, a placeholder used only in code, or some combination of
the two?

Luckily it really is just a message (or rather, a value for the commit
message column in the " f7c0c00 [ahead 58, behind 197] vcs-svn: drop
obj_pool.h" message).

For what it's worth, assuming this passes tests,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>