Re: [PATCH v2 1/3] branch: reject -D/-d without branch name
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 25, 2013, 19:04 UTC
- Message-ID
- <7vham53x01.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <1359118225-14356-1-git-send-email-pclouds@gmail.com>
Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
> --- > builtin/branch.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-)
Forgot to sign-off?
Is this a real problem?
I do not see it particularly wrong to succeed after deleting 0 or more given branch names.
Show 19 quoted lines
>
> diff --git a/builtin/branch.c b/builtin/branch.c
> index 873f624..50fcacc 100644
> --- a/builtin/branch.c
> +++ b/builtin/branch.c
> @@ -837,9 +837,11 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
> colopts = 0;
> }
>
> - if (delete)
> + if (delete) {
> + if (!argc)
> + die(_("branch name required"));
> return delete_branches(argc, argv, delete > 1, kinds, quiet);
> - else if (list) {
> + } else if (list) {
> int ret = print_ref_list(kinds, detached, verbose, abbrev,
> with_commit, argv);
> print_columns(&output, colopts, NULL);