git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/3] branch: reject -D/-d without branch name

From
Duy Nguyen <pclouds@gmail.com>
Date
Jan 26, 2013, 03:12 UTC
Message-ID
<CACsJy8B1YS6EDNFzDL3zJiy5tb3Qn=0xxyZgSnQh4KM6yNNKpw@mail.gmail.com>
In-Reply-To
<7vham53x01.fsf@alter.siamese.dyndns.org>
On Sat, Jan 26, 2013 at 2:04 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 7 quoted lines
> Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
>
>> ---
>>  builtin/branch.c | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> Forgot to sign-off?
Yes
> Is this a real problem?
Yes. My thoughts yesterday when I happened to type "git branch -D":

"Wait, I just entered a delete command without a branch name. It did not report anything, which in UNIX world usually means successful operation. _What_ did it delete??"

I knew this code so I just went check. If I did not know, I might as well list all branches I had and see if something was missing. A short message would have saved me the trouble.

> I do not see it particularly wrong to succeed after deleting 0 or
> more given branch names.
-- 
Duy
Previous: Junio C HamanoNext: Nguyễn Thái Ngọc Duy
Message 10 of 14 in “branch: reject -D/-d without branch name”
  1. branch: reject -D/-d without branch nameNguyễn Thái Ngọc Duy, Jan 25, 2013
  2. Matthieu MoyJan 25, 2013
  3. Duy NguyenJan 25, 2013
  4. 1/3 branch: reject -D/-d without branch nameNguyễn Thái Ngọc Duy, Jan 25, 2013
  5. 2/3 branch: give a more helpful message on redundant argumentsNguyễn Thái Ngọc Duy, Jan 25, 2013
  6. Jonathan NiederJan 27, 2013
  7. 3/3 branch: mark more strings for translationNguyễn Thái Ngọc Duy, Jan 25, 2013
  8. Jonathan NiederJan 27, 2013
  9. Junio C HamanoJan 25, 2013
  10. Duy NguyenJan 26, 2013
  11. 1/4 branch: no detached HEAD check when editing another branch's descriptionNguyễn Thái Ngọc Duy, Jan 28, 2013
  12. 2/4 branch: reject -D/-d without branch nameNguyễn Thái Ngọc Duy, Jan 28, 2013
  13. 3/4 branch: give a more helpful message on redundant argumentsNguyễn Thái Ngọc Duy, Jan 28, 2013
  14. 4/4 branch: mark more strings for translationNguyễn Thái Ngọc Duy, Jan 28, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.