Re: [PATCH] branch: reject -D/-d without branch name

From: Duy Nguyen <pclouds@gmail.com>
Date: Jan 25, 2013, 08:56 UTC
Message-ID: <CACsJy8AyDKEFG511e70vB7YrwLP4xoWmE34tqazMZA59hs6iHA@mail.gmail.com>
In-Reply-To: <vpqmwvxhcra.fsf@grenoble-inp.fr>

On Fri, Jan 25, 2013 at 3:45 PM, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:

Show 18 quoted lines

> Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
>
>> diff --git a/builtin/branch.c b/builtin/branch.c
>> index 873f624..1d3e842 100644
>> --- a/builtin/branch.c
>> +++ b/builtin/branch.c
>> @@ -837,7 +837,7 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
>>               colopts = 0;
>>       }
>>
>> -     if (delete)
>> +     if (delete && argc)
>>               return delete_branches(argc, argv, delete > 1, kinds, quiet);
>>       else if (list) {
>>               int ret = print_ref_list(kinds, detached, verbose, abbrev,
>
> Shouldn't this error out with a clean error message ("branch name
> expected" or so)?

Yeah. But on the other hand, this command seems to prefer to print help usage when incorrect number of arguments is given (checkout blocks "if (edit_description)" and "if (rename)" in cmd_branch). Should those be fixed too?

-- 
Duy