git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 00/15] Hierarchical reference cache (once again)

From
Jeff King <peff@peff.net>
Date
Apr 12, 2012, 06:44 UTC
Message-ID
<20120412064459.GD27369@sigill.intra.peff.net>
In-Reply-To
<1334035827-20331-1-git-send-email-mhagger@alum.mit.edu>
On Tue, Apr 10, 2012 at 07:30:12AM +0200, mhagger@alum.mit.edu wrote:
Show 16 quoted lines
> Michael Haggerty (15):
>   refs.c: reorder definitions more logically
>   refs: manage current_ref within do_one_ref()
>   do_for_each_ref_in_array(): new function
>   do_for_each_ref_in_arrays(): new function
>   repack_without_ref(): reimplement using do_for_each_ref_in_array()
>   names_conflict(): new function, extracted from is_refname_available()
>   names_conflict(): simplify implementation
>   is_refname_available(): reimplement using do_for_each_ref_in_array()
>   free_ref_entry(): new function
>   check_refname_component(): return 0 for zero-length components
>   struct ref_entry: nest the value part in a union
>   refs.c: rename ref_array -> ref_dir
>   sort_ref_dir(): simplify logic
>   refs: store references hierarchically
>   do_for_each_ref(): only iterate over the subtree that was requested

I read through the whole series and didn't find anything noticeably wrong. Overall, it was quite readable for such a large series. Thanks for breaking it up as you did.

-Peff
Previous: mhagger@alum.mit.eduNext: Junio C Hamano
Message 17 of 18 in “Hierarchical reference cache (once again)”
  1. 00/15 Hierarchical reference cache (once again)mhagger@alum.mit.edu, Apr 10, 2012
  2. 01/15 refs.c: reorder definitions more logicallymhagger@alum.mit.edu, Apr 10, 2012
  3. 02/15 refs: manage current_ref within do_one_ref()mhagger@alum.mit.edu, Apr 10, 2012
  4. 03/15 do_for_each_ref_in_array(): new functionmhagger@alum.mit.edu, Apr 10, 2012
  5. 04/15 do_for_each_ref_in_arrays(): new functionmhagger@alum.mit.edu, Apr 10, 2012
  6. 05/15 repack_without_ref(): reimplement using do_for_each_ref_in_array()mhagger@alum.mit.edu, Apr 10, 2012
  7. 06/15 names_conflict(): new function, extracted from is_refname_available()mhagger@alum.mit.edu, Apr 10, 2012
  8. 07/15 names_conflict(): simplify implementationmhagger@alum.mit.edu, Apr 10, 2012
  9. 08/15 is_refname_available(): reimplement using do_for_each_ref_in_array()mhagger@alum.mit.edu, Apr 10, 2012
  10. 09/15 free_ref_entry(): new functionmhagger@alum.mit.edu, Apr 10, 2012
  11. 10/15 check_refname_component(): return 0 for zero-length componentsmhagger@alum.mit.edu, Apr 10, 2012
  12. 11/15 struct ref_entry: nest the value part in a unionmhagger@alum.mit.edu, Apr 10, 2012
  13. 12/15 refs.c: rename ref_array -> ref_dirmhagger@alum.mit.edu, Apr 10, 2012
  14. 13/15 sort_ref_dir(): simplify logicmhagger@alum.mit.edu, Apr 10, 2012
  15. 14/15 refs: store references hierarchicallymhagger@alum.mit.edu, Apr 10, 2012
  16. 15/15 do_for_each_ref(): only iterate over the subtree that was requestedmhagger@alum.mit.edu, Apr 10, 2012
  17. Jeff KingApr 12, 2012
  18. Junio C HamanoApr 12, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.