git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 15/15] do_for_each_ref(): only iterate over the subtree that was requested

From
mhagger@alum.mit.edu <mhagger@alum.mit.edu>
Date
Apr 10, 2012, 05:30 UTC
Message-ID
<1334035827-20331-16-git-send-email-mhagger@alum.mit.edu>
In-Reply-To
<1334035827-20331-1-git-send-email-mhagger@alum.mit.edu>
From: Michael Haggerty <mhagger@alum.mit.edu>

If the base argument has a "/" chararacter, then only iterate over the reference subdir whose name is the part up to the last "/".

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
 refs.c |   35 ++++++++++++++++++++++++++++-------
 1 file changed, 28 insertions(+), 7 deletions(-)
diff --git a/refs.c b/refs.c
index cdfb53d..f97a256 100644
--- a/refs.c
+++ b/refs.c
@@ -1144,13 +1144,34 @@ static int do_for_each_ref(const char *submodule, const char *base, each_ref_fn
 			   int trim, int flags, void *cb_data)
 {
 	struct ref_cache *refs = get_ref_cache(submodule);
-	struct ref_dir *packed_refs = get_packed_refs(refs);
-	struct ref_dir *loose_refs = get_loose_refs(refs);
-	sort_ref_dir(packed_refs);
-	sort_ref_dir(loose_refs);
-	return do_for_each_ref_in_dirs(packed_refs,
-				       loose_refs,
-				       base, fn, trim, flags, cb_data);
+	struct ref_dir *packed_dir = get_packed_refs(refs);
+	struct ref_dir *loose_dir = get_loose_refs(refs);
+	int retval = 0;
+
+	if (base && *base) {
+		packed_dir = find_containing_dir(packed_dir, base, 0);
+		loose_dir = find_containing_dir(loose_dir, base, 0);
+	}
+
+	if (packed_dir && loose_dir) {
+		sort_ref_dir(packed_dir);
+		sort_ref_dir(loose_dir);
+		retval = do_for_each_ref_in_dirs(
+				packed_dir, loose_dir,
+				base, fn, trim, flags, cb_data);
+	} else if (packed_dir) {
+		sort_ref_dir(packed_dir);
+		retval = do_for_each_ref_in_dir(
+				packed_dir, 0,
+				base, fn, trim, flags, cb_data);
+	} else if (loose_dir) {
+		sort_ref_dir(loose_dir);
+		retval = do_for_each_ref_in_dir(
+				loose_dir, 0,
+				base, fn, trim, flags, cb_data);
+	}
+
+	return retval;
 }
 
 static int do_head_ref(const char *submodule, each_ref_fn fn, void *cb_data)
-- 
1.7.10
Previous: mhagger@alum.mit.eduNext: Jeff King
Message 16 of 18 in “Hierarchical reference cache (once again)”
  1. 00/15 Hierarchical reference cache (once again)mhagger@alum.mit.edu, Apr 10, 2012
  2. 01/15 refs.c: reorder definitions more logicallymhagger@alum.mit.edu, Apr 10, 2012
  3. 02/15 refs: manage current_ref within do_one_ref()mhagger@alum.mit.edu, Apr 10, 2012
  4. 03/15 do_for_each_ref_in_array(): new functionmhagger@alum.mit.edu, Apr 10, 2012
  5. 04/15 do_for_each_ref_in_arrays(): new functionmhagger@alum.mit.edu, Apr 10, 2012
  6. 05/15 repack_without_ref(): reimplement using do_for_each_ref_in_array()mhagger@alum.mit.edu, Apr 10, 2012
  7. 06/15 names_conflict(): new function, extracted from is_refname_available()mhagger@alum.mit.edu, Apr 10, 2012
  8. 07/15 names_conflict(): simplify implementationmhagger@alum.mit.edu, Apr 10, 2012
  9. 08/15 is_refname_available(): reimplement using do_for_each_ref_in_array()mhagger@alum.mit.edu, Apr 10, 2012
  10. 09/15 free_ref_entry(): new functionmhagger@alum.mit.edu, Apr 10, 2012
  11. 10/15 check_refname_component(): return 0 for zero-length componentsmhagger@alum.mit.edu, Apr 10, 2012
  12. 11/15 struct ref_entry: nest the value part in a unionmhagger@alum.mit.edu, Apr 10, 2012
  13. 12/15 refs.c: rename ref_array -> ref_dirmhagger@alum.mit.edu, Apr 10, 2012
  14. 13/15 sort_ref_dir(): simplify logicmhagger@alum.mit.edu, Apr 10, 2012
  15. 14/15 refs: store references hierarchicallymhagger@alum.mit.edu, Apr 10, 2012
  16. 15/15 do_for_each_ref(): only iterate over the subtree that was requestedmhagger@alum.mit.edu, Apr 10, 2012
  17. Jeff KingApr 12, 2012
  18. Junio C HamanoApr 12, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.