git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 10/15] check_refname_component(): return 0 for zero-length components

From
mhagger@alum.mit.edu <mhagger@alum.mit.edu>
Date
Apr 10, 2012, 05:30 UTC
Message-ID
<1334035827-20331-11-git-send-email-mhagger@alum.mit.edu>
In-Reply-To
<1334035827-20331-1-git-send-email-mhagger@alum.mit.edu>
From: Michael Haggerty <mhagger@alum.mit.edu>

Return 0 (instead of -1) for zero-length components. Move the interpretation of zero-length components as illegal to check_refname_format().

This will make it easier to extend check_refname_format() to also check whether directory names are valid.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
 refs.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/refs.c b/refs.c
index 8659c3e..1f6890b 100644
--- a/refs.c
+++ b/refs.c
@@ -51,7 +51,7 @@ static int check_refname_component(const char *refname, int flags)
 		last = ch;
 	}
 	if (cp == refname)
-		return -1; /* Component has zero length. */
+		return 0; /* Component has zero length. */
 	if (refname[0] == '.') {
 		if (!(flags & REFNAME_DOT_COMPONENT))
 			return -1; /* Component starts with '.'. */
@@ -74,7 +74,7 @@ int check_refname_format(const char *refname, int flags)
 	while (1) {
 		/* We are at the start of a path component. */
 		component_len = check_refname_component(refname, flags);
-		if (component_len < 0) {
+		if (component_len <= 0) {
 			if ((flags & REFNAME_REFSPEC_PATTERN) &&
 					refname[0] == '*' &&
 					(refname[1] == '\0' || refname[1] == '/')) {

-- 
1.7.10
Previous: mhagger@alum.mit.eduNext: mhagger@alum.mit.edu
Message 11 of 18 in “Hierarchical reference cache (once again)”
  1. 00/15 Hierarchical reference cache (once again)mhagger@alum.mit.edu, Apr 10, 2012
  2. 01/15 refs.c: reorder definitions more logicallymhagger@alum.mit.edu, Apr 10, 2012
  3. 02/15 refs: manage current_ref within do_one_ref()mhagger@alum.mit.edu, Apr 10, 2012
  4. 03/15 do_for_each_ref_in_array(): new functionmhagger@alum.mit.edu, Apr 10, 2012
  5. 04/15 do_for_each_ref_in_arrays(): new functionmhagger@alum.mit.edu, Apr 10, 2012
  6. 05/15 repack_without_ref(): reimplement using do_for_each_ref_in_array()mhagger@alum.mit.edu, Apr 10, 2012
  7. 06/15 names_conflict(): new function, extracted from is_refname_available()mhagger@alum.mit.edu, Apr 10, 2012
  8. 07/15 names_conflict(): simplify implementationmhagger@alum.mit.edu, Apr 10, 2012
  9. 08/15 is_refname_available(): reimplement using do_for_each_ref_in_array()mhagger@alum.mit.edu, Apr 10, 2012
  10. 09/15 free_ref_entry(): new functionmhagger@alum.mit.edu, Apr 10, 2012
  11. 10/15 check_refname_component(): return 0 for zero-length componentsmhagger@alum.mit.edu, Apr 10, 2012
  12. 11/15 struct ref_entry: nest the value part in a unionmhagger@alum.mit.edu, Apr 10, 2012
  13. 12/15 refs.c: rename ref_array -> ref_dirmhagger@alum.mit.edu, Apr 10, 2012
  14. 13/15 sort_ref_dir(): simplify logicmhagger@alum.mit.edu, Apr 10, 2012
  15. 14/15 refs: store references hierarchicallymhagger@alum.mit.edu, Apr 10, 2012
  16. 15/15 do_for_each_ref(): only iterate over the subtree that was requestedmhagger@alum.mit.edu, Apr 10, 2012
  17. Jeff KingApr 12, 2012
  18. Junio C HamanoApr 12, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.