git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 09/15] free_ref_entry(): new function

From
mhagger@alum.mit.edu <mhagger@alum.mit.edu>
Date
Apr 10, 2012, 05:30 UTC
Message-ID
<1334035827-20331-10-git-send-email-mhagger@alum.mit.edu>
In-Reply-To
<1334035827-20331-1-git-send-email-mhagger@alum.mit.edu>
From: Michael Haggerty <mhagger@alum.mit.edu>

Add a function free_ref_entry(). This function will become nontrivial when ref_entry (soon) becomes polymorphic.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
 refs.c |    9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/refs.c b/refs.c
index 4b94b08..8659c3e 100644
--- a/refs.c
+++ b/refs.c
@@ -145,6 +145,11 @@ static struct ref_entry *create_ref_entry(const char *refname,
 	return ref;
 }
 
+static void free_ref_entry(struct ref_entry *entry)
+{
+	free(entry);
+}
+
 /* Add a ref_entry to the end of the ref_array (unsorted). */
 static void add_ref(struct ref_array *refs, struct ref_entry *ref)
 {
@@ -156,7 +161,7 @@ static void clear_ref_array(struct ref_array *array)
 {
 	int i;
 	for (i = 0; i < array->nr; i++)
-		free(array->refs[i]);
+		free_ref_entry(array->refs[i]);
 	free(array->refs);
 	array->sorted = array->nr = array->alloc = 0;
 	array->refs = NULL;
@@ -235,7 +240,7 @@ static void sort_ref_array(struct ref_array *array)
 	i = 0;
 	for (j = 1; j < array->nr; j++) {
 		if (is_dup_ref(array->refs[i], array->refs[j])) {
-			free(array->refs[j]);
+			free_ref_entry(array->refs[j]);
 			continue;
 		}
 		array->refs[++i] = array->refs[j];
-- 
1.7.10
Previous: mhagger@alum.mit.eduNext: mhagger@alum.mit.edu
Message 10 of 18 in “Hierarchical reference cache (once again)”
  1. 00/15 Hierarchical reference cache (once again)mhagger@alum.mit.edu, Apr 10, 2012
  2. 01/15 refs.c: reorder definitions more logicallymhagger@alum.mit.edu, Apr 10, 2012
  3. 02/15 refs: manage current_ref within do_one_ref()mhagger@alum.mit.edu, Apr 10, 2012
  4. 03/15 do_for_each_ref_in_array(): new functionmhagger@alum.mit.edu, Apr 10, 2012
  5. 04/15 do_for_each_ref_in_arrays(): new functionmhagger@alum.mit.edu, Apr 10, 2012
  6. 05/15 repack_without_ref(): reimplement using do_for_each_ref_in_array()mhagger@alum.mit.edu, Apr 10, 2012
  7. 06/15 names_conflict(): new function, extracted from is_refname_available()mhagger@alum.mit.edu, Apr 10, 2012
  8. 07/15 names_conflict(): simplify implementationmhagger@alum.mit.edu, Apr 10, 2012
  9. 08/15 is_refname_available(): reimplement using do_for_each_ref_in_array()mhagger@alum.mit.edu, Apr 10, 2012
  10. 09/15 free_ref_entry(): new functionmhagger@alum.mit.edu, Apr 10, 2012
  11. 10/15 check_refname_component(): return 0 for zero-length componentsmhagger@alum.mit.edu, Apr 10, 2012
  12. 11/15 struct ref_entry: nest the value part in a unionmhagger@alum.mit.edu, Apr 10, 2012
  13. 12/15 refs.c: rename ref_array -> ref_dirmhagger@alum.mit.edu, Apr 10, 2012
  14. 13/15 sort_ref_dir(): simplify logicmhagger@alum.mit.edu, Apr 10, 2012
  15. 14/15 refs: store references hierarchicallymhagger@alum.mit.edu, Apr 10, 2012
  16. 15/15 do_for_each_ref(): only iterate over the subtree that was requestedmhagger@alum.mit.edu, Apr 10, 2012
  17. Jeff KingApr 12, 2012
  18. Junio C HamanoApr 12, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.