Re: [PATCH 1/3] t9350: point out that refs are not updated correctly

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Nov 7, 2011, 09:32 UTC
Message-ID: <20111107093249.GD30641@elie.hsd1.il.comcast.net>
In-Reply-To: <CAGdFq_hmF8xDA8PdDUPygSSAVsvrA=BRVKp+eCVRggHxLZzBsQ@mail.gmail.com>

Sverre Rabbelier wrote:

> On Sun, Nov 6, 2011 at 05:31, Jonathan Nieder <jrnieder@gmail.com> wrote:

>>> as they use marks
>>> files to store which commits have already been seen. The call graph
>>> is something as follows:

[...]

Show 10 quoted lines

>>> $ # run `git branch foo` and push it to remote
>>> $ git fast-export --{im,ex}port-marks=marksfile foo
>>>
>>> When fast-export imports the marksfile and sees that all commits in
>>> foo are marked as UNINTERESTING
>>
>> Hmm, I didn't know about this behavior.  Would it be possible to add
>> a test for it, too?
>
> What behavior are you referring to here? What kind of test would you want added?

I meant I hadn't remembered that marks result in commits being marked as UNINTERESTING (even though the manpage warned me), and that it's possible a priori that fast-export could be broken when you run

	git fast-export --import-marks=marksfile master

even without breaking

	git fast-export master..master

But don't worry about it --- I can try it as a follow-on when this series next visits the list if that doesn't sound like fun. :)

FWIW, with the clarifications to the commit message Junio made, I'm happy with this patch.