git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/4] Honor core.ignorecase for attribute patterns

From
Jeff King <peff@peff.net>
Date
Sep 15, 2011, 18:12 UTC
Message-ID
<20110915181258.GA1227@sigill.intra.peff.net>
In-Reply-To
<1316051979-19671-1-git-send-email-drafnel@gmail.com>
On Wed, Sep 14, 2011 at 08:59:35PM -0500, Brandon Casey wrote:
Show 6 quoted lines
> > I haven't even tested that it runs. :)  No, I was hoping someone
> > who was more interested would finish it, and maybe even test on
> > an affected system.
> 
> Ok, I lied.  Here's a series that needs testing by people on a
> case-insensitive filesystem and some comments.

Thanks. I was trying to decide if I was interested enough to work on it, but procrastination wins again.

I'm not sure I understand why you need a case-insensitive file system for the final set of tests. If we have a case-sensitive system, we can force the filesystem to show us whatever cases we want, and check against them with both core.ignorecase off and on[1]. What are these tests checking that requires the actual behavior of a case-insensitive filesystem?

I'm sure there is something subtle that I'm missing. Can you explain it either here or in the commit message?

-Peff

[1] Actually, I wondered at first if the other tests needed to be marked for only case-sensitive systems, since we can't rely on the behavior of insensitive ones (e.g., are they case-preserving, always downcasing, etc). But looking at t0003, we don't seem to actually create the files in the filesystem at all.

Previous: Brandon CaseyNext: Brandon Casey
Message 11 of 19 in “Honor core.ignorecase for attribute patterns”
  1. 0/4 Honor core.ignorecase for attribute patternsBrandon Casey, Sep 15, 2011
  2. 1/4 attr.c: avoid inappropriate access to strbuf "buf" memberBrandon Casey, Sep 15, 2011
  3. 2/4 cleanup: use internal memory allocation wrapper functions everywhereBrandon Casey, Sep 15, 2011
  4. Johannes SixtSep 15, 2011
  5. Brandon CaseySep 15, 2011
  6. 3/4 builtin/mv.c: plug miniscule memory leakBrandon Casey, Sep 15, 2011
  7. 4/4 attr.c: respect core.ignorecase when matching attribute patternsBrandon Casey, Sep 15, 2011
  8. Junio C HamanoSep 15, 2011
  9. Junio C HamanoSep 15, 2011
  10. Brandon CaseySep 15, 2011
  11. Jeff KingSep 15, 2011
  12. Brandon CaseySep 15, 2011
  13. Brandon CaseyOct 6, 2011
  14. Johannes SixtOct 6, 2011
  15. Alexey ShumkinOct 6, 2011
  16. Brandon CaseyOct 6, 2011
  17. Erik Faye-LundOct 6, 2011
  18. Erik Faye-LundOct 6, 2011
  19. Brandon CaseyOct 6, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.