From: Jeff King <peff@peff.net>
Date: Thu, 15 Sep 2011 18:12:58 GMT
Subject: Re: [PATCH 0/4] Honor core.ignorecase for attribute patterns
Message-ID: <20110915181258.GA1227@sigill.intra.peff.net>
In-Reply-To: <1316051979-19671-1-git-send-email-drafnel@gmail.com>

On Wed, Sep 14, 2011 at 08:59:35PM -0500, Brandon Casey wrote:

> > I haven't even tested that it runs. :)  No, I was hoping someone
> > who was more interested would finish it, and maybe even test on
> > an affected system.
> 
> Ok, I lied.  Here's a series that needs testing by people on a
> case-insensitive filesystem and some comments.

Thanks. I was trying to decide if I was interested enough to work on it,
but procrastination wins again.

I'm not sure I understand why you need a case-insensitive file system
for the final set of tests. If we have a case-sensitive system, we can
force the filesystem to show us whatever cases we want, and check
against them with both core.ignorecase off and on[1]. What are these
tests checking that requires the actual behavior of a case-insensitive
filesystem?

I'm sure there is something subtle that I'm missing. Can you explain it
either here or in the commit message?

-Peff

[1] Actually, I wondered at first if the other tests needed to be marked
for only case-sensitive systems, since we can't rely on the behavior of
insensitive ones (e.g., are they case-preserving, always downcasing,
etc). But looking at t0003, we don't seem to actually create the files
in the filesystem at all.