Re: [PATCH 4/4] attr.c: respect core.ignorecase when matching attribute patterns

From: Brandon Casey <drafnel@gmail.com>
Date: Sep 15, 2011, 15:38 UTC
Message-ID: <CA+sFfMd7B6suV1YQppJGJmoCr+du3-GaG5dFhp=DyEngb-wR4g@mail.gmail.com>
In-Reply-To: <7vobymqwjf.fsf@alter.siamese.dyndns.org>

On Wed, Sep 14, 2011 at 11:06 PM, Junio C Hamano <gitster@pobox.com> wrote:

>
> Junio C Hamano <gitster@pobox.com> writes:

Show 5 quoted lines

> > An alternative approach may be to move reading of core.attributesfile to
> > default_config, and drop git_config() call from bootstrap_attr_stack(),
> > getting rid of git_attr_config callback altogether.
>
> That is, something like this on top of your patch.

Ok.

I'll send a reroll that slides this underneath my top patch, and addresses Hanne's comment.

-Brandon

Show 6 quoted lines

>  attr.c               |   15 ++-------------
>  builtin/check-attr.c |    2 ++
>  cache.h              |    1 +
>  config.c             |    3 +++
>  environment.c        |    1 +
>  5 files changed, 9 insertions(+), 13 deletions(-)